Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures children are correctly handled when not varargs #721

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

nadenf
Copy link
Contributor

@nadenf nadenf commented Aug 9, 2024

Fixes #720

Need to update compiler targets as there was a compiler crash with the existing versions.

@nadenf nadenf changed the title Ensure children are correctly rendered Ensures children are correctly handled when not varargs Aug 9, 2024
@nadenf nadenf force-pushed the fix-children branch 6 times, most recently from b6afeb1 to 89472d0 Compare August 11, 2024 12:24
@nadenf nadenf closed this Aug 12, 2024
@nadenf nadenf reopened this Aug 12, 2024
Copy link
Owner

@shadaj shadaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Sorry for the delay in getting to this.

@shadaj shadaj merged commit 0ce16f7 into shadaj:main Nov 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Children are not correctly handled when not varargs
3 participants