Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntactic sugar for onBeforeInput & onBeforeInputCapture #696

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

strobe
Copy link
Contributor

@strobe strobe commented Feb 4, 2024

this intended to address part of #689 which is not covered by #695

Add onBeforeInput & onBeforeInputCapture handlers .

As result following code should work:

input(onBeforeInputCapture := (event => { println(s"onBeforeInputCapture, data: ${event.data}") }),
      onBeforeInput := (event => { println(s"onBeforeInput, data: ${event.data}") }))

@strobe
Copy link
Contributor Author

strobe commented Feb 15, 2024

Later I should update this to adjust according on recent #695 changes

@strobe
Copy link
Contributor Author

strobe commented Feb 26, 2024

@shadaj sorry, I forgot to comment here on last week that this PR was updated

Copy link
Owner

@shadaj shadaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@shadaj shadaj merged commit 4d5b3bc into shadaj:main Feb 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants