fix(data): Re-import Sant Singh Khalsa English translation for Sri Guru Granth Sahib #1800

sarabveer · 2021-01-02T05:04:50Z

Summary of PR

Re-import English translation from Dr. Sant Singh Khalsa. Siri Guru Granth Sahib Ji. Vol. 1-5. Edition 2.5, SikhNet, November 2015.

This is similar to PR #273, which used the gurbanifiles.net version of the translation

http://report.sikhnet.com/files/2013/10/SGGS_Gurmukhi_English_Vol_1_edition2.5_Nov_19_2015.pdf
http://report.sikhnet.com/files/2013/10/SGGS_Gurmukhi_English_Vol_2_edition2.5_Nov_19_2015.pdf
http://report.sikhnet.com/files/2013/10/SGGS_Gurmukhi_English_Vol_3_edition2.5_Nov_19_2015.pdf
http://report.sikhnet.com/files/2013/10/SGGS_Gurmukhi_English_Vol_4_edition2.5_Nov_19_2015.pdf
http://report.sikhnet.com/files/2013/10/SGGS_Gurmukhi_English_Vol_5_edition2.5_Nov_19_2015.pdf

Tests for unexpected behavior

none_whatsoever

Time spent on PR

nine_thousand_years

Linked issues

Fix #

Reviewers

@

Final to do

Check whitespace and trim where needed
Make list of Gurbani lines that were together due to translation

Closes #1787

Dr. Sant Singh Khalsa. Siri Guru Granth Sahib Ji. Vol. 1. Edition 2.5, SikhNet, November 2015.

bhajneet

This is great work so far. I see you've completed volume 1 in this draft. I've made a few suggestions before you finish, perhaps it will save you some time in the following volumes. Once you're done, it would be good to see two things in the completed PR in addition to what you've worked on:

Hyphens moved to the first segment: I did not do a proper search for this
All lines that are split / combined: I would like to see all of these in an easy list, so we can confirm they actually make sense.

data/Sri Guru Granth Sahib Ji/0012.json

data/Sri Guru Granth Sahib Ji/0141.json

data/Sri Guru Granth Sahib Ji/0187.json

data/Sri Guru Granth Sahib Ji/0196.json

data/Sri Guru Granth Sahib Ji/0220.json

bhajneet · 2021-01-02T16:20:51Z

data/Sri Guru Granth Sahib Ji/0253.json

@@ -307,7 +307,7 @@
        "translations": {
          "English": {
            "Dr. Sant Singh Khalsa": {
-              "translation": "Does not have to take birth again.",
+              "translation": "does not have to take birth again.",


The translations should be reversed with the previous line (as we have done in other examples). Current and Suggested below.

Currently:

ਯਯਾ; ਜਨਮਿ ਨ ਆਵੈ ਸੋਊ ॥ XXw; jnim n AwvY soaU ] Yaya: One who weaves the One Name into his heart ਏਕ ਨਾਮ ਲੇ; ਮਨਹਿ ਪਰੋਊ ॥ eyk nwm ly; mnih proaU ] does not have to take birth again.

Suggested

ਯਯਾ; ਜਨਮਿ ਨ ਆਵੈ ਸੋਊ ॥ XXw; jnim n AwvY soaU ] Yaya: One does not have to take birth again, ਏਕ ਨਾਮ ਲੇ; ਮਨਹਿ ਪਰੋਊ ॥ eyk nwm ly; mnih proaU ] who weaves the One Name into his heart.

Regarding this, I did not change the order of the words themselves, only flipped the sentenced based on punctuation.

Original:

Yaya: One who weaves the One Name into his heart
does not have to take birth again.

What I would have done:

Yaya: Does not have to take birth again
One who weaves the One Name into his heart.

I think its more true to the source, but indeed it sounds odd.

Your suggestion is more true to the source I suppose. But it sounds a bit like Yoda did the translation haha 😄. We can leave it either way, I still think it makes more sense per my suggestion, and I don't think it hurts the integrity of the source translation.

bhajneet · 2021-01-02T16:27:36Z

data/Sri Guru Granth Sahib Ji/0257.json

@@ -2050,7 +2050,7 @@
        "translations": {
          "English": {
            "Dr. Sant Singh Khalsa": {
-              "translation": "The Name of the Lord, shall not fall into hell.",
+              "translation": "the Name of the Lord, shall not fall into hell.",


Recommended to reverse these translations as well. Current and suggested below.

Current:

ਨੰਨਾ; ਨਰਕਿ ਪਰਹਿ ਤੇ ਨਾਹੀ ॥ nµnw; nrik prih qy nwhI ] NANNA: Those whose minds and bodies are filled with the Naam, ਜਾ ਕੈ ਮਨਿ ਤਨਿ; ਨਾਮੁ ਬਸਾਹੀ ॥ jw kY min qin; nwmu bswhI ] the Name of the Lord, shall not fall into hell.

Suggested

ਨੰਨਾ; ਨਰਕਿ ਪਰਹਿ ਤੇ ਨਾਹੀ ॥ nµnw; nrik prih qy nwhI ] NANNA: Those shall not fall into hell, ਜਾ ਕੈ ਮਨਿ ਤਨਿ; ਨਾਮੁ ਬਸਾਹੀ ॥ jw kY min qin; nwmu bswhI ] whose minds and bodies are filled with the Naam, the Name of the Lord.

bhajneet · 2021-01-02T16:32:26Z

data/Sri Guru Granth Sahib Ji/0257.json

@@ -2242,7 +2242,7 @@
        "translations": {
          "English": {
            "Dr. Sant Singh Khalsa": {
-              "translation": "Shall not be turned away.",
+              "translation": "shall not be turned away.",


Another suggested reversal. Current and suggested below.

Current:

ਨੰਨਾਕਾਰੁ; ਨ ਹੋਤਾ ਤਾ ਕਹੁ ॥ nµnwkwru; n hoqw qw khu ] Those who have been given the Mantra of the Naam by the Guru, ਨਾਮੁ ਮੰਤ੍ਰੁ; ਗੁਰਿ ਦੀਨੋ ਜਾ ਕਹੁ ॥ nwmu mMqRü; guir dIno jw khu ] shall not be turned away.

Suggested:

ਨੰਨਾਕਾਰੁ; ਨ ਹੋਤਾ ਤਾ ਕਹੁ ॥ nµnwkwru; n hoqw qw khu ] Those shall not be turned away, ਨਾਮੁ ਮੰਤ੍ਰੁ; ਗੁਰਿ ਦੀਨੋ ਜਾ ਕਹੁ ॥ nwmu mMqRü; guir dIno jw khu ] who have been given the Mantra of the Naam by the Guru.

data/Sri Guru Granth Sahib Ji/0282.json

sarabveer · 2021-01-02T21:10:12Z

1. Hyphens moved to the first segment: I did not do a proper search for this

About this, the current method is to have the hyphen in the second segment. Please look at the images below:

(Only 2 results for hyphen at the end)

The trend throughout the DB is to have the hyphen in the beginning of the second segment.

bhajneet · 2021-01-02T21:16:42Z

1. Hyphens moved to the first segment: I did not do a proper search for this
About this, the current method is to have the hyphen in the second segment. Please look at the images below:

(Only 2 results for hyphen at the end)

The trend throughout the DB is to have the hyphen in the beginning of the second segment.

I understand the trend. I don't think it makes more sense to put the hyphen at the beginning of a line. Similar to how it makes less sense to move a comma or semi colon to the beginning of a second line.

sarabveer · 2021-01-02T21:19:32Z

I understand the trend. I don't think it makes more sense to put the hyphen at the beginning of a line. Similar to how it makes less sense to move a comma or semi colon to the beginning of a second line.

Alright, I'll do a separate commit moving them to the beginning.

bhajneet · 2021-01-02T21:25:11Z

Alright, I'll do a separate commit moving them to the beginning.

Please save this commit for the end so I can review before hand. I've added it as a checkbox to the OP as a reminder.

sarabveer · 2021-01-02T21:28:49Z

@bhajneet In regards to the flipped translations, maybe it is best to have a column in the future Notes table with the original sentence?

However, this PR would then be dependent on #95

bhajneet · 2021-01-02T21:44:39Z

@bhajneet In regards to the flipped translations, maybe it is best to have a column in the future Notes table with the original sentence?

However, this PR would then be dependent on #95

It's possible to use the extra notes section for this. I don't believe it is necessary though.

It seems there are two generic ways we are altering the source:

Splitting the translation as is across two lines
Re-arranging or reversing the translation to make better sense across two lines

In the first case what we can do is append [...] to indicate a continuing quotation

In the second what is normally done is use words in square brackets to fit the quote properly. Or use brackets/parentheses (mla vs apa) to indicate an altered quote, emphasis added, etc.

It would then be on the developers to remove instances of [...] when combining passages. It would not be possible for developers to fix the reversed quotes programmatically. So if that ends up being a popular request we can re-visit the idea of using the notes column or another solution.

For now, I would say clarifying to the reader both scenarios above is enough, (assuming we're not harming the integrity of the quote, which we aren't).

sarabveer · 2021-01-02T22:07:57Z

I don't think the usage of [...] is needed when a translation is split across two lines. If the line is split properly, the translation still "flows" properly when reading.

What I can do is make a list of lines in the translation that were originally together, then one by one they can be split or flipped.

sarabveer · 2021-01-02T23:28:18Z

Seeing as the original source also has the hyphen on the second line, will just keep as is.

Dr. Sant Singh Khalsa. Siri Guru Granth Sahib Ji. Vol. 1. Edition 2.5, SikhNet, November 2015. http://report.sikhnet.com/files/2013/10/SGGS_Gurmukhi_English_Vol_2_edition2.5_Nov_19_2015.pdf

Dr. Sant Singh Khalsa. Siri Guru Granth Sahib Ji. Vol. 3. Edition 2.5, SikhNet, November 2015. http://report.sikhnet.com/files/2013/10/SGGS_Gurmukhi_English_Vol_3_edition2.5_Nov_19_2015.pdf

bhajneet

Good so far

Dr. Sant Singh Khalsa. Siri Guru Granth Sahib Ji. Vol. 4. Edition 2.5, SikhNet, November 2015. https://report.sikhnet.com/files/2013/10/SGGS_Gurmukhi_English_Vol_4_edition2.5_Nov_19_2015.pdf

Dr. Sant Singh Khalsa. Siri Guru Granth Sahib Ji. Vol. 5. Edition 2.5, SikhNet, November 2015. https://report.sikhnet.com/files/2013/10/SGGS_Gurmukhi_English_Vol_5_edition2.5_Nov_19_2015.pdf

sarabveer · 2022-05-15T19:38:33Z

data/Sri Guru Granth Sahib Ji/1339.json

@@ -2542,7 +2542,7 @@
        "translations": {
          "English": {
            "Dr. Sant Singh Khalsa": {
-              "translation": "Those, whose minds are filled with the Word of the Guru's Bani,",
+              "translation": "All pains and afflictions run away from those,",


Need to check this.

Another case of flipped translation. Will be included in list.

sarabveer · 2022-08-24T05:55:09Z

I am going to open another issue with a list of lines that have their translations not 1:1 with the Gurbani Gurmukhi line.

sarabveer · 2023-11-18T02:27:07Z

Just to note, the SSK translation is now on its fourth edition. This PR used edition 3.5.

fix(data): Import Vol. 1 of Sant Singh Khalsa English translation

2b12b12

Dr. Sant Singh Khalsa. Siri Guru Granth Sahib Ji. Vol. 1. Edition 2.5, SikhNet, November 2015.

sarabveer self-assigned this Jan 2, 2021

bhajneet reviewed Jan 2, 2021

View reviewed changes

sarabveer added 2 commits January 2, 2021 20:22

fix(data): Import Vol. 2 of Sant Singh Khalsa English translation

ade85e4

Dr. Sant Singh Khalsa. Siri Guru Granth Sahib Ji. Vol. 1. Edition 2.5, SikhNet, November 2015. http://report.sikhnet.com/files/2013/10/SGGS_Gurmukhi_English_Vol_2_edition2.5_Nov_19_2015.pdf

fix(data): trim whitespace from importing Vol. 2 of SSK translation

af7df29

Base automatically changed from dev to main February 7, 2021 23:56

fix(data): Import Vol. 3 of Sant Singh Khalsa English translation

3610a3c

Dr. Sant Singh Khalsa. Siri Guru Granth Sahib Ji. Vol. 3. Edition 2.5, SikhNet, November 2015. http://report.sikhnet.com/files/2013/10/SGGS_Gurmukhi_English_Vol_3_edition2.5_Nov_19_2015.pdf

bhajneet reviewed Jun 13, 2021

View reviewed changes

bhajneet removed the Status: WIP label Oct 18, 2021

sarabveer and others added 3 commits May 14, 2022 15:41

Merge branch 'next' into sant_singh_khalsa

a0f18df

fix(data): Import Vol. 4 of Sant Singh Khalsa English translation

2e0ad0b

Dr. Sant Singh Khalsa. Siri Guru Granth Sahib Ji. Vol. 4. Edition 2.5, SikhNet, November 2015. https://report.sikhnet.com/files/2013/10/SGGS_Gurmukhi_English_Vol_4_edition2.5_Nov_19_2015.pdf

fix(data): Import Vol. 5 of Sant Singh Khalsa English translation

50f32c8

Dr. Sant Singh Khalsa. Siri Guru Granth Sahib Ji. Vol. 5. Edition 2.5, SikhNet, November 2015. https://report.sikhnet.com/files/2013/10/SGGS_Gurmukhi_English_Vol_5_edition2.5_Nov_19_2015.pdf

sarabveer commented May 15, 2022

View reviewed changes

sarabveer added 6 commits May 15, 2022 16:45

fix(data): split Sant Singh Khalsa translation of lines QDYH and V606

5a7e916

fix(data): Split Sant Singh Khalsa translation of lines 3WEB and X9FP

905b2fc

fix(data): Split Sant Singh Khalsa translation of lines W6H6 and 8KTB

7b6a817

fix(data): Split Sant Singh Khalsa translation of lines V9HS and Q7GT

9eb9086

fix(data): split Sant Singh Khalsa translation of lines 2Z8J and TB0X

8e78ac9

fix(data): split Sant Singh Khalsa translation of lines ZXGM and 4290

ded2dee

sarabveer force-pushed the sant_singh_khalsa branch from 5ceb569 to ded2dee Compare May 15, 2022 21:46

sarabveer added 9 commits May 16, 2022 11:56

fix(data): split Sant Singh Khalsa translation of lines FNS5 and 8VJG

a0661ea

fix(data): split Sant Singh Khalsa translation of lines KMCK and W6P3

a4439c9

fix(data): split Sant Singh Khalsa translation for shabad SZ4

994bc9a

fix(data): split Sant Singh Khalsa translation for shabad 4WM

2697fbe

fix(data): split Sant Singh Khalsa translation of lines 8R7N and MAST

daf502c

fix(data): split Sant Singh Khalsa translation of lines 7ABD and K2Y1

09c605f

fix(data): split Sant Singh Khalsa translation of lines 102P and 6N8Y

f16ada6

fix(data): split Sant Singh Khalsa translation of lines PRPJ and 3UK7

727ba26

fix(data): split Sant Singh Khalsa translation for shabad 59X

48ffaa8

sarabveer force-pushed the sant_singh_khalsa branch from a0d4305 to 48ffaa8 Compare August 24, 2022 04:46

sarabveer added 9 commits August 24, 2022 00:56

fix(data): split Sant Singh Khalsa translation of lines 58G5 and 30UC

5561a99

fix(data): split Sant Singh Khalsa translation of lines JKQU and Z4MC

b5480e3

fix(data): split Sant Singh Khalsa translation of lines K40Z and YHS7

9b5e0ba

fix(data): split Sant Singh Khalsa translation of lines 3A0C and HLAU

6c90704

fix(data): split Sant Singh Khalsa translation of lines 777M and DUK7

18414e0

fix(data): split Sant Singh Khalsa translation of lines 54BX and G3BK

f656cf5

fix(data): split Sant Singh Khalsa translation of lines NTNC and SK5H

c3787c2

fix(data): split Sant Singh Khalsa translation of lines GU7U and WD31

89b57dd

fix(data): split Sant Singh Khalsa translation for shabad NDH

d0cf727

sarabveer marked this pull request as ready for review August 24, 2022 05:54

sarabveer mentioned this pull request Aug 24, 2022

Some translations in SSK English do not match 1:1 with Gurbani Gurmukhi line #1883

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(data): Re-import Sant Singh Khalsa English translation for Sri Guru Granth Sahib #1800

fix(data): Re-import Sant Singh Khalsa English translation for Sri Guru Granth Sahib #1800

sarabveer commented Jan 2, 2021 •

edited

Loading

bhajneet left a comment

bhajneet Jan 2, 2021

sarabveer Jan 2, 2021

bhajneet Jan 2, 2021

bhajneet Jan 2, 2021

bhajneet Jan 2, 2021

sarabveer commented Jan 2, 2021

bhajneet commented Jan 2, 2021

sarabveer commented Jan 2, 2021

bhajneet commented Jan 2, 2021

sarabveer commented Jan 2, 2021

bhajneet commented Jan 2, 2021

sarabveer commented Jan 2, 2021

sarabveer commented Jan 2, 2021 •

edited

Loading

bhajneet left a comment

sarabveer May 15, 2022

sarabveer Aug 24, 2022

sarabveer commented Aug 24, 2022 •

edited

Loading

sarabveer commented Nov 18, 2023

fix(data): Re-import Sant Singh Khalsa English translation for Sri Guru Granth Sahib #1800

Are you sure you want to change the base?

fix(data): Re-import Sant Singh Khalsa English translation for Sri Guru Granth Sahib #1800

Conversation

sarabveer commented Jan 2, 2021 • edited Loading

Summary of PR

Tests for unexpected behavior

Time spent on PR

Linked issues

Reviewers

Final to do

bhajneet left a comment

Choose a reason for hiding this comment

bhajneet Jan 2, 2021

Choose a reason for hiding this comment

sarabveer Jan 2, 2021

Choose a reason for hiding this comment

bhajneet Jan 2, 2021

Choose a reason for hiding this comment

bhajneet Jan 2, 2021

Choose a reason for hiding this comment

bhajneet Jan 2, 2021

Choose a reason for hiding this comment

sarabveer commented Jan 2, 2021

bhajneet commented Jan 2, 2021

sarabveer commented Jan 2, 2021

bhajneet commented Jan 2, 2021

sarabveer commented Jan 2, 2021

bhajneet commented Jan 2, 2021

sarabveer commented Jan 2, 2021

sarabveer commented Jan 2, 2021 • edited Loading

bhajneet left a comment

Choose a reason for hiding this comment

sarabveer May 15, 2022

Choose a reason for hiding this comment

sarabveer Aug 24, 2022

Choose a reason for hiding this comment

sarabveer commented Aug 24, 2022 • edited Loading

sarabveer commented Nov 18, 2023

sarabveer commented Jan 2, 2021 •

edited

Loading

sarabveer commented Jan 2, 2021 •

edited

Loading

sarabveer commented Aug 24, 2022 •

edited

Loading