Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit rustfmt config #2285

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Explicit rustfmt config #2285

merged 1 commit into from
Aug 31, 2024

Conversation

kornelski
Copy link
Contributor

I have my custom rustfmt configuration, which automatically "breaks" formatting in projects that assume the default formatting. This change explicitly selects the formatting that is required.

@alex
Copy link
Collaborator

alex commented Aug 30, 2024

Hmm, is this typical? It seems to me that part of the point of using defaults it not needing to configure anything :-)

@kornelski
Copy link
Contributor Author

Rustfmt supports system-wide configuration.

I need to use non-default config, which clashes with projects that demand rustfmt-formatted code assuming defaults.

Copy link
Collaborator

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm skeptical that system-wide config was a good idea for rustfmt, but given that it supports it, this seems like an inevitable need.

@alex alex merged commit 48824a6 into sfackler:master Aug 31, 2024
61 checks passed
@kornelski kornelski deleted the rustfmt branch August 31, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants