Add reading X509 certificate extensions #2032
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktor-k
commented
Aug 30, 2023
| unsafe { | ||
| let loc = ffi::X509_get_ext_by_NID(self.as_ptr(), nid.as_raw(), -1); | ||
| Ok(if loc >= 0 { | ||
| Some(X509ExtensionRef::from_ptr(cvt_p(ffi::X509_get_ext( |
There was a problem hiding this comment.
I'm kind of not sure if cvt_p is necessary here or whether returned null pointer can just be converted into None (that'd remove the Result from function signature, making it simpler). The docs doesn't seem to be conclusive on this matter: X509_get_ext :/
wiktor-k
force-pushed
the
add-get-ext
branch
2 times, most recently
from
e8d7eca
to
29c0984
Compare
wiktor-k
force-pushed
the
add-get-ext
branch
from
29c0984
to
7dc6281
Compare
|
Sorry for disrupting but I was wondering if there's anything that prevents this PR from being merged? I'm planning to use read extensions produced by Yubico and would appreciate review. Thank you for your time! 🙏 |
|
Ping @alex. I hope you don't mind :) |
This function allows reading extension data bytes.
This function allows retrieving extensions from X509 certificates using NID objects.
This function allows retrieving extensions from X509 certificates using ASN1 Object IDs.
|
@sfackler is there anything preventing this from being merged? Thanks! 👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
This PR adds
X509::get_ext_by_{nid,obj}functions for retrieving extensions out of X509 certificates as well asX509Extension::datafunction for reading the actual value.I've also added test fixture - a certificate with extension to be read.
I've made it into a single function that reads the first extension with the given Nid (OID) but I'm open to suggestions if I should split them into two functions. (current approach allows reading only the first extension with given Nid but it's sufficient for my needs).