Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify runtime argument #952

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

matthias-pichler
Copy link
Collaborator

Signed-off-by: Matthias Pichler m.pichler@warrify.com

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

Closes #950

What this PR does:

Documents the $runtime argument

Additional information:

Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas cdavernas added change: documentation Improvements or additions to documentation. It won't impact a version change. change: feature New feature or request. Impacts in a minor version change area: spec Changes in the Specification labels Aug 4, 2024
@cdavernas cdavernas added this to the v1.0.0-alpha3 milestone Aug 4, 2024
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks man ❤️

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't see this link in the original discussion. Please disregard my comment there.

Looks good to me, can you please rebase it?

@matthias-pichler
Copy link
Collaborator Author

@ricardozanini done 👍

@cdavernas cdavernas merged commit 151392d into serverlessworkflow:main Aug 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: spec Changes in the Specification change: documentation Improvements or additions to documentation. It won't impact a version change. change: feature New feature or request. Impacts in a minor version change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add $runtime argument for implementation specific information
3 participants