Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linters to CI #883

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

matthias-pichler
Copy link
Collaborator

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

What this PR does:

I added the super-linter action to lint & format yaml and markdown files.

I also updated the contributing guide to use the same packages as super-lint. (Specifically markdown-lint instead of mdl)

And I formated and linted all files to make them compliant.

Additional information:

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good! I believe you're still working on GHA. 👍

@matthias-pichler matthias-pichler marked this pull request as draft June 4, 2024 15:19
@matthias-pichler
Copy link
Collaborator Author

The changes look good! I believe you're still working on GHA. 👍

It might actually be that super-linter is looking for the config files on the main branch and therefore can't find it 🤔

@ricardozanini
Copy link
Member

The changes look good! I believe you're still working on GHA. 👍

It might actually be that super-linter is looking for the config files on the main branch and therefore can't find it 🤔

Maybe we can open another PR and then rebase this one?

Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks ❤️

@cdavernas cdavernas requested review from ricardozanini and removed request for tsurdilo and antmendoza June 12, 2024 12:00
@matthias-pichler matthias-pichler mentioned this pull request Jun 27, 2024
8 tasks
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link

github-actions bot commented Oct 4, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cicd Changes in the CI/CD Stale PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants