Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.0-alpha1: attempt#1 #846

Closed
wants to merge 76 commits into from

Conversation

cdavernas
Copy link
Member

@cdavernas cdavernas commented May 20, 2024

Many thanks for submitting your Pull Request ❤️!

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Roadmap
  • Use Cases
  • Community
  • TCK
  • Other

Discussion or Issue link:
#843

What this PR does / why we need it:

The version 1.0.0-alpha1 is one of the most impacting release of the history of the Serverless Workflow DSL. It aims at both drastically simplify the DSL and at completing it with many new features.

It is intended to be the last release containing breaking changes before the Serverless Workflow DSL 1.0.0 can see the day.

What's new?

@cdavernas
Copy link
Member Author

cdavernas commented May 20, 2024

Refactor preview
WIP

@cdavernas cdavernas added change: documentation Improvements or additions to documentation. It won't impact a version change. help wanted Extra attention is needed area: spec Changes in the Specification change: breaking A breaking change that will impact in a major version change. area: ctk Changes in the CTK (Compliance Test Kit) area: cicd Changes in the CI/CD labels May 20, 2024
@cdavernas cdavernas added this to the v1.0-alpha milestone May 20, 2024
@cdavernas cdavernas changed the title 1.0.0 alpha1 1.0.0-alpha1 May 20, 2024
@cdavernas
Copy link
Member Author

@ricardozanini @fjtirado I took the freedom of renaming TCK, which is apparently specifically used for Java, by CTK, but it does however change the meaning a bit from Technology Compatibility Kit into Compliance Test Kit. There is also the option of simply changing the meaning of the acronym into Technology Compliance Kit or something like that.

WDYT?

@cdavernas
Copy link
Member Author

@ricardozanini Do we need to include the annual reviews, and if so, can we move them to a properly cased directory (such as annual-reviews)?

What about the meetingminutes directory? Do we still need it? If so, can we properly case it (such as meeting-minutes, or move it to a relevant subdirectory such as community)

@cdavernas
Copy link
Member Author

@ricardozanini We will need to refactor comparisons, if we believe it's necessary to keep them. If so, could you guys @ricardozanini @fjtirado take care of it?

@cdavernas
Copy link
Member Author

@ricardozanini @fjtirado I removed the examples instead of just updating them, because I believe this role is fullfilled by the Gherkin features, and is even more intelligible imho. What do you guys think?

@cdavernas
Copy link
Member Author

@ricardozanini @fjtirado Could you guys also take care of creating use cases (for documentation), and Gherkin tests, if need be, for the CTK?

@ricardozanini ricardozanini requested review from fjtirado and JBBianchi and removed request for tsurdilo and antmendoza May 20, 2024 15:53
@ricardozanini
Copy link
Member

@ricardozanini Do we need to include the annual reviews, and if so, can we move them to a properly cased directory (such as annual-reviews)?

We can keep those in the folder annual-reviews, but I think CNCF is ditching those. Until we can confirm this info I think we can keep it there.

What about the meetingminutes directory? Do we still need it? If so, can we properly case it (such as meeting-minutes, or move it to a relevant subdirectory such as community)

Please ditch this one, we have the discussions: https://github.com/serverlessworkflow/specification/discussions/categories/meetings-notes

@ricardozanini
Copy link
Member

@ricardozanini We will need to refactor comparisons, if we believe it's necessary to keep them. If so, could you guys @ricardozanini @fjtirado take care of it?

I don't think we need those.

@ricardozanini
Copy link
Member

@ricardozanini @fjtirado I removed the examples instead of just updating them, because I believe this role is fullfilled by the Gherkin features, and is even more intelligible imho. What do you guys think?

We need to be able to validate the schema somehow. The examples are good for this, plus newcomers can grasp the DSL easier with them, IMO.

@ricardozanini
Copy link
Member

@ricardozanini @fjtirado Could you guys also take care of creating use cases (for documentation), and Gherkin tests, if need be, for the CTK?

Sure thing, it will also be a great way to validate our refactoring and use cases.

@cdavernas
Copy link
Member Author

We need to be able to validate the schema somehow. The examples are good for this, plus newcomers can grasp the DSL easier with them, IMO.

Indeed. As for the schema, I'm working on it. It's a big piece.

Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
cdavernas and others added 26 commits May 21, 2024 10:32
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
@cdavernas cdavernas closed this May 21, 2024
@cdavernas cdavernas deleted the 1.0.0-alpha1 branch May 21, 2024 09:01
@cdavernas cdavernas changed the title 1.0.0-alpha1 1.0.0-alpha1 attempt 1 May 21, 2024
@cdavernas cdavernas changed the title 1.0.0-alpha1 attempt 1 1.0.0-alpha1: attempt#1 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cicd Changes in the CI/CD area: ctk Changes in the CTK (Compliance Test Kit) area: spec Changes in the Specification change: breaking A breaking change that will impact in a major version change. change: documentation Improvements or additions to documentation. It won't impact a version change. help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants