Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed examples hydration breaking samples in README #823

Merged

Conversation

JBBianchi
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Roadmap
  • Use Cases
  • Community
  • TCK
  • Other

Discussion or Issue link:

#822

What this PR does / why we need it:

It should fix the samples in the examples README.

Special notes for reviewers:

Additional information:

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you sign your commit? 😬

@JBBianchi
Copy link
Member Author

Can you sign your commit? 😬

I tried to amend but it looks like I failed yet again. I'll delete this branch and redo the PR sorry :/

@ricardozanini
Copy link
Member

@JBBianchi usually I amend and push -f

Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
@JBBianchi
Copy link
Member Author

I managed after some brawling against git 💪

@ricardozanini ricardozanini merged commit 9f79f8f into serverlessworkflow:main Feb 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants