Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unevaluatedProperties false to oauth2AuthenticationProperties #1008

Conversation

JBBianchi
Copy link
Member

@JBBianchi JBBianchi commented Sep 6, 2024

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

Closes #1007

What this PR does:

  • adds unevaluatedProperties: false to oauth2AuthenticationProperties
  • adds 2 examples to validate the use-case

Additional information:

Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
@JBBianchi JBBianchi force-pushed the fix-1007-conflicting-oauth2-policy-oneof branch from 8c04e04 to 4ad1d2d Compare September 6, 2024 12:55
@cdavernas cdavernas added area: spec Changes in the Specification change: fix Something isn't working. Impacts in a minor version change. labels Sep 6, 2024
@cdavernas cdavernas added this to the v1.0.0 milestone Sep 6, 2024
@cdavernas cdavernas merged commit 6a52595 into serverlessworkflow:main Sep 6, 2024
3 checks passed
@cdavernas cdavernas deleted the fix-1007-conflicting-oauth2-policy-oneof branch September 6, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: spec Changes in the Specification change: fix Something isn't working. Impacts in a minor version change.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

OAuth2 Authentication policy conflicting oneOf
3 participants