Merge pull request #120 from antmendoza/throw-error-if-validator-not-…

…found Throws error if validator function not found
serverlessworkflow · Jul 13, 2021 · a6903ad · a6903ad
2 parents c620a72 + 7721a04
commit a6903ad
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/lib/utils.ts b/src/lib/utils.ts
@@ -24,8 +24,11 @@ import { validators } from './validators';
  */
 export const validate = (typeName: string, data: any): boolean => {
   const validateFn: ValidateFunction | undefined = validators.get(typeName);
-  // TODO: ignore validation if no validator or throw ?
-  if (!validateFn) return data;
+
+  if (!validateFn) {
+    throw Error(`Validate function not defined for type '${typeName}'`);
+  }
+
   if (!validateFn(data)) {
     console.warn(validateFn.errors);
     const firstError: DefinedError = (validateFn.errors as DefinedError[])[0];

diff --git a/tests/lib/utils.spec.ts b/tests/lib/utils.spec.ts
@@ -24,4 +24,8 @@ describe('validate', () => {
   it('should return true for valid objects', () => {
     expect(validate('End', false)).toBeTruthy('Expected function validate to return true for valid objects');
   });
+
+  it('should throws an error if validator not found', () => {
+    expect(() => validate('ValidatorNotDefined', {})).toThrowError();
+  });
 });