Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serverless-dynamodb examples #774

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from

Conversation

domdomegg
Copy link

The examples involving currently serverless-dynamodb-local are quite out of date. They use an older configuration API which makes it hard for new users to get started. In addition, the package serverless-dynamodb-local no longer works as the hardcoded URL it contains has broken, and it uses an old access key format that isn't compatible with new versions of DynamoDB Local. Lastly, several of the docs are just wrong in places - e.g. I suspect a copy/paste mistake has resulted in people listing the wrong endpoints for a REST API (API Gateway v1) by copying them from the HTTP API (API Gateway v2) example.

This PR:

@domdomegg
Copy link
Author

Fixes #773

@domdomegg
Copy link
Author

Requesting review from @medikoo

@medikoo
Copy link

medikoo commented Feb 8, 2024

@domdomegg thank for pinging. Still I'm no longer with Serverless Inc, and I don't have necessary rights to review and merge any work here.
I believe it's @ac360 who's handling the contributions now

@domdomegg
Copy link
Author

Ah thanks! @ac360 are you able to review?

@domdomegg
Copy link
Author

@eahefnawy Can you review this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants