Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to configure sequra from command line #23

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

m1k3lm
Copy link
Member

@m1k3lm m1k3lm commented Jul 10, 2024

What is the goal?

Have a way to setup seQura minimun configuration using CLI

How is it being implemented?

Created a Symfony Console command

bin/magento sequra:configure --merchant_ref="${SQ_MERCHANT_REF}" \
    --username="${SQ_USER_NAME}" \
    --assets_key="${SQ_ASSETS_KEY}" \
    --endpoint="${SQ_ENDPOINT}" \
    --password="${SQ_USER_SECRET}"

Opportunistic refactorings

Changed version number to X.Y.Z format required by Adobe App Store

Caveats

Does it affect (changes or update) any sensitive data?

No

How is it tested?

Manual tests

How is it going to be deployed?

Standard deployment

@m1k3lm m1k3lm closed this Jul 11, 2024
@m1k3lm m1k3lm reopened this Jul 11, 2024
@m1k3lm m1k3lm marked this pull request as ready for review July 11, 2024 07:22
Copy link
Contributor

@mescalantea mescalantea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m1k3lm m1k3lm merged commit ef3a5ee into master Jul 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants