Fix widget amount #16
Conversation
| $product->getPriceInfo()->getPrice('regular_price')->getMinimalPrice()->getValue() : | ||
| $product->getFinalPrice()); | ||
|
|
||
| if ($product->getTypeId() === 'bundle' || !$this->isTaxEnabled()) { |
There was a problem hiding this comment.
Bundled products will have taxes too, no?
Shouldn't we always take the price with taxes included? Even when taxes are not enabled it will be the same prices as the price without taxes
There was a problem hiding this comment.
For bundle products, regular price is always equal to the price displayed in catalog pages - if tax is enabled, regular price will contain the tax, if tax is disabled, regular price will be without tax.
There was a problem hiding this comment.
That is why I'm commenting it because we will always charge the prices with tax included.
There was a problem hiding this comment.
I think that the fix should always use the price with tax included with no exceptions.
There was a problem hiding this comment.
Hey @m1k3lm Let's keep the communication about the issue in the ticket. Our team will respond in the ticket itself -> https://sequra.atlassian.net/browse/LIS-13
What is the goal?
Fix reported issue with widget amount when product price has more than 2 decimals.
How is it being implemented?
When product price is converted to minor unit, it is multiplied by 100, rounded to 0 decimals and cast to integer.
Does it affect (changes or update) any sensitive data?
No.
How is it tested?
Manual tests.
In Magento 2 shop, enable taxes and set a Tax rule with a percentage that has several decimals. On storefront, check the widgets on product pages.
How is it going to be deployed?
Standard deployment