Added support for redis clustered mode #735
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: munishchouhan <hrma017@gmail.com>
Signed-off-by: munishchouhan <hrma017@gmail.com>
Signed-off-by: munishchouhan <hrma017@gmail.com>
pditommaso
reviewed
Nov 6, 2024
| * | ||
| * @author Munish Chouhan <munish.chouhan@seqera.io> | ||
| */ | ||
| interface RedisService { |
There was a problem hiding this comment.
Not sure to understand the need for this?
There was a problem hiding this comment.
JedisCluster and JedisPool doesnot have common Interface, so not possible to inject
Thats why I have created this service which have separate implementation for cluster and standalone and based on redis.mode it will be initialized
This reverts commit 31640e4.
Signed-off-by: munishchouhan <hrma017@gmail.com>
|
We may need to reconsider this, at least in the short run. I was considering a much smaller impact. Also, Platform is not supporting cluster mode for sure, so there's not benefit adding the support for Wave |
|
we can move further with ssl+auth, which is currently required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add support for redis clustered mode