Add cyberchef container, nginx location, and link in layout.html #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added entry for cyberchef:latest image from github container repository (official GCHQ source)
added location directive to point to the cyberchef_current container image.
adding cyberchef button to layout.html.
-changing the font awesome icon to icon-book. -icons are supplied by /app/static/bootstrap/img/glyphicons-halflings.png -icon-food (which would've been neat for cyberchef isn't in this icon set) but icon-book (menu? recipes?) is included. -font awesome would need to be updated to use icon-food (page says it was added in 3.0, and Dalton uses 2.3.5 - https://origin.fontawesome.com/v3/icon/food) -another good icon might be icon-share?
xssfox
approved these changes
Nov 25, 2024
|
That looks good, should merge next week if I get the chance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again,
This is another pull request, intended to address #229
Here are the Changes I am proposing:
dalton/docker-compose.yml
ghcr.io/gchq/cyberchef:latestdalton/nginx-conf/conf.d/dalton.conf
/cyberchef/resolve 127.0.0.11;to use docker's internal DNS to resolve the hostnamecyberchef_current-- this is very important.proxy_pass http://cyberchef_current/;to redirect users to the cyberchef instance correctlyproxy_set_headerdirectives were required to interact with cyberchef.dalton/app/templates/dalton/layout.html
icon-foodfor cyberchef. I agree this would look great, however,icon-foodis NOT available indalton/app/static/bootstrap/img/glyphicons-halflings.png. According font-awesome, this icon was added with version 3.0 (https://origin.fontawesome.com/v3/icon/food). I have opted to useicon-bookinstead (menu? recipe book?), buticon-sharemight be an option as well.Results:
The end-product:
When the Cyberchef button is clicked:
The landing page for cyber chef becomes accessible.