Put viewer's Lua functionality behind a feature flag, default off. #2523
Conversation
Add tests to verify that llless() correctly handles signed <=> unsigned comparison, which native "<" does not.
Appending is effected by passing position == getItemCount(). Until now, insert() disallowed that value, so you could insert before the last existing entry but not after it.
'pos' is a 0-relative index at which to insert the desired menu item or separator. If 'pos' is omitted, the item is appended to the menu.
Make central Lua engine functionality conditional on that flag.
Add a menus.lua autorun script that waits until login, then adds the Lua floaters back into the Develop->Consoles menu where they were originally. Extend UI.addMenuItem() and addMenuSeparator() to support pos argument.
| // Reserve -1 return to mean event has no "pos" key. | ||
| S32 get_pos(const LLSD& event, U32 size) | ||
| { | ||
| return event["pos"].isInteger()? llclamp(event["pos"].asInteger(), 0, size) : -1; |
There was a problem hiding this comment.
0 menu position is used for 'double line' in the top menu (which allows to undock that menu). Should we allow inserting new items before it, basically pushing 'double line' down? It's ok for me if you think we should (though it's somewhat inconsistent), Otherwise, let's clamp to 1.
There was a problem hiding this comment.
Hmm! I based this llclamp() call on the test in LLMenuGL::insert(). Are you saying that if we allow inserting at 0, tearing off the menu would leave that first (inserted) item attached to the top menu?
If we change this to 1, should we also change the test in LLMenuGL::insert()?
There was a problem hiding this comment.
Using test_top_menu.lua: current script vs inserting "Debug console" at 0.
I'm not sure about LLMenuGL::insert(). As far as I remember, only top menus have these 'tear-off' items(LLMenuItemTearOffGL). So, it makes sense to allow inserting at 0 in general( maybe, the exception is the top menu).
There was a problem hiding this comment.
The menus.lua autorun script I added definitely manipulates the branch menu Develop->Consoles. Granted, it's not trying to insert at the top.
From what you're saying, to clamp this properly I think we would need to query the specified parent menu to discover whether it's a top menu or a branch menu.
When disabled, the Lua machinery simply returns an error message.
Remove Lua floaters from the default menu structure, but add a Lua autorun script to dynamically re-add them if Lua is enabled.