-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate namespace pages #439
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: DebbieAtSeam <145377258+DebbieAtSeam@users.noreply.github.com>
Co-authored-by: DebbieAtSeam <145377258+DebbieAtSeam@users.noreply.github.com>
@andrii-balitskyi We need to update all links (find / replace) to point to this file now instead of Line 167 in 6a5cf81
|
const namespaceMetadata = pathMetadata[path] | ||
if (namespaceMetadata == null) continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const namespaceMetadata = pathMetadata[path] | |
if (namespaceMetadata == null) continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this? I thought we needed to skip generating pages for namespaces without metadata from path.yaml
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line will skip the namespace silently, but this error will fail generation if the namespace meta is missing with a loud error we can fix right? I think we should prefer the error https://github.com/seamapi/docs/pull/439/files#diff-0a3594c2f3f590fc60789732487e494609fc157e29857e33691d171331a8dd6cR23
docs/api/acs/README.md
Outdated
|
||
## Resources | ||
|
||
### `acs_system` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add the links, I think this would be correct.
### `acs_system` | |
### [`acs_system`](./systems/README.md#acs_system) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if I correctly compute the link using pathMetadata
c3dbdf0
.gitbook.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrii-balitskyi This file must remain unchanged or it will break all of the redirects from the old URLs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted the file in def5b59
Closes #399