Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Benchmark #50

wants to merge 2 commits into from

Conversation

priyasiddharth
Copy link
Collaborator

pop_back benchmark jobs runs in same amount of time.
swap_contents job runs much faster

To help debug: #24

@priyasiddharth priyasiddharth linked an issue Jan 6, 2021 that may be closed by this pull request
mallocing slows down cex mode #24
Open
@priyasiddharth
Copy link
Collaborator Author

Re-running this today, I'm getting sat for swap_contents which is unexpected since I merely downloaded the original code and made cosmetic changes. I am still debugging but my reccomendation is to holdoff merging.

@agurfinkel
Copy link
Collaborator

ok. There is one job that is expected to fail on aws-c-common (they still have not fixed AWS_IS_ZERO. Need to check again. But this is unrelated to your issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agurfinkel agurfinkel Awaiting requested review from agurfinkel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mallocing slows down cex mode
2 participants
@priyasiddharth @agurfinkel