-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monads refactor #660
Monads refactor #660
Conversation
In some following work I got a bit annoyed by the random order of files in I'm happy to go with a different order or even revert and ignore it if people prefer. |
af8630e
to
351bc85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. While going through the files, I was wondering if we should also go for WhileLoopRules
-> While_Loop_Rules
, but I'm not sure I care enough :-)
I'm happy with the reordering. |
351bc85
to
c010be5
Compare
Good idea, that is definitely more consistent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done. The new names will take a while to get used to, but at they're consistent now.
Signed-off-by: Corey Lewis <corey.lewis@proofcraft.systems>
Signed-off-by: Corey Lewis <corey.lewis@proofcraft.systems>
Signed-off-by: Corey Lewis <corey.lewis@proofcraft.systems>
Signed-off-by: Corey Lewis <corey.lewis@proofcraft.systems>
Signed-off-by: Corey Lewis <corey.lewis@proofcraft.systems>
Signed-off-by: Corey Lewis <corey.lewis@proofcraft.systems>
c010be5
to
42ca5b3
Compare
Separate out the different monads into subdirectories and use a consistent naming scheme with prefixes. This is in preparation for the trace monad to be eventually expanded to match the nondet monad, which will lead to a lot of similar files.
For reviewing purposes, I think the main things to look at are the names and locations of the files in the
monads
directory and subdirectories. Almost all other changes are the result ofsed
commands.