Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monads refactor #660

Merged
merged 6 commits into from
Aug 9, 2023
Merged

Monads refactor #660

merged 6 commits into from
Aug 9, 2023

Conversation

corlewis
Copy link
Member

Separate out the different monads into subdirectories and use a consistent naming scheme with prefixes. This is in preparation for the trace monad to be eventually expanded to match the nondet monad, which will lead to a lot of similar files.

For reviewing purposes, I think the main things to look at are the names and locations of the files in the monads directory and subdirectories. Almost all other changes are the result of sed commands.

@corlewis
Copy link
Member Author

In some following work I got a bit annoyed by the random order of files in Monads/ROOT, so I took the opportunity to reorder it. I didn't put that much thought into it, I was mainly wanting to be consistent and group related files. There's almost definitely further improvements that could be made if dependencies were also considered.

I'm happy to go with a different order or even revert and ignore it if people prefer.

Copy link
Member

@lsf37 lsf37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. While going through the files, I was wondering if we should also go for WhileLoopRules -> While_Loop_Rules, but I'm not sure I care enough :-)

@lsf37
Copy link
Member

lsf37 commented Aug 7, 2023

In some following work I got a bit annoyed by the random order of files in Monads/ROOT, so I took the opportunity to reorder it. I didn't put that much thought into it, I was mainly wanting to be consistent and group related files. There's almost definitely further improvements that could be made if dependencies were also considered.

I'm happy to go with a different order or even revert and ignore it if people prefer.

I'm happy with the reordering.

@corlewis
Copy link
Member Author

corlewis commented Aug 8, 2023

Looking good. While going through the files, I was wondering if we should also go for WhileLoopRules -> While_Loop_Rules, but I'm not sure I care enough :-)

Good idea, that is definitely more consistent.

Copy link
Member

@Xaphiosis Xaphiosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. The new names will take a while to get used to, but at they're consistent now.

Signed-off-by: Corey Lewis <corey.lewis@proofcraft.systems>
Signed-off-by: Corey Lewis <corey.lewis@proofcraft.systems>
Signed-off-by: Corey Lewis <corey.lewis@proofcraft.systems>
Signed-off-by: Corey Lewis <corey.lewis@proofcraft.systems>
Signed-off-by: Corey Lewis <corey.lewis@proofcraft.systems>
Signed-off-by: Corey Lewis <corey.lewis@proofcraft.systems>
@corlewis corlewis merged commit aa8b108 into seL4:master Aug 9, 2023
13 checks passed
@corlewis corlewis deleted the monads_refactor branch August 9, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants