[#26] Add padding for img component
#58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 I'm not sure about this. The image being close to text indicate they belong together, and reduces the amount of scrolling too. I don't think it hinders the reader that much. Also, this issue appears only when there is text immediately above the image and is separated by a |
|
Would it be preferable to leave it unchanged instead? Or are there any better alternatives? |
Yes, for now, let's leave it as is. We can revisit it at a later time. |
|
Closing this for now ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26
Description:
Modified
main.cssto giveimgcomponents a padding of20pxfor improved readability as mentioned in #26.Screenshots:
Before:
After: