Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker guidance #1245

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

makrsmark
Copy link
Contributor

@makrsmark makrsmark commented Aug 10, 2024

use TCP for feeding dumpvdl2 to airframes

* use TCP for feeding dumpvdl2 to airframes
* rename `docker-compose.yml` to `compose.yml`
* remove version from `compose.yml`
Comment on lines -149 to +150
# The line below should uncommented if you are receiving VDLM and DO NOT want to feed aiframes
# The line below should uncommented if you are receiving VDLM, using dumpvdl2 OR using vdlm2dec and not want to feed
#- AR_SEND_UDP_VDLM2=acarshub:5555
# The line below should uncommented if you are receiving VDLM, using dumpvdl2 AND want to feed airframes
#- AR_SEND_UDP_VDLM2=acarshub:5555;feed.airframes.io:5552
#- AR_SEND_TCP_VDLM2=feed.airframes.io:5553
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am open to wording suggestions to better indicate BOTH lines should be uncommented to feed to airframes using dumpvdl2

@dziban303
Copy link
Contributor

We use docker-compose.yml throughout the sdr-e ecosystem, I see absolutely no reason to change that

@makrsmark
Copy link
Contributor Author

Changed it to what's preferred by docker, but that's fine it can stay

https://docs.docker.com/compose/compose-application-model/#the-compose-file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants