Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): restrict release branches in automation #1765

Merged
merged 8 commits into from
Nov 18, 2024

Conversation

ilan-gold
Copy link
Contributor

I guess we could also check that

  • Closes #
  • Tests added
  • Release note added (or unnecessary)

@ilan-gold ilan-gold added this to the 0.11.2 milestone Nov 14, 2024
@ilan-gold ilan-gold marked this pull request as ready for review November 14, 2024 10:03
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.51%. Comparing base (af6480e) to head (3501c83).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1765      +/-   ##
==========================================
- Coverage   87.01%   84.51%   -2.50%     
==========================================
  Files          40       40              
  Lines        6059     6059              
==========================================
- Hits         5272     5121     -151     
- Misses        787      938     +151     

see 8 files with indirect coverage changes

ci/scripts/towncrier_automation.py Outdated Show resolved Hide resolved
@flying-sheep
Copy link
Member

I guess we could also check that

that what? 😄

@ilan-gold
Copy link
Contributor Author

that what? 😄

My brain has been completely fried these past few dayss.......I honestly don't remember

Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
@ilan-gold ilan-gold merged commit 2602e5b into main Nov 18, 2024
15 checks passed
@ilan-gold ilan-gold deleted the ig/no_patch_release_on_main_error branch November 18, 2024 12:46
meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request Nov 18, 2024
ilan-gold added a commit that referenced this pull request Nov 18, 2024
…1771)

Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants