-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 0.11 docs with rcs #1752
Merge 0.11 docs with rcs #1752
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems doable @flying-sheep but maybe not a huge priority since it only needs to be done on >minor releases. Maybe a python markdown parser + script that runs in the release job?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to figure out how other big projects seem to do it and if I see it right, they:
- Have full release notes per RC -> RC 3 also has all changes of RC2 and RC1 and not just the diff between RCs
- The final release has ALL changes and does not mention the RCs again.
- If I see this right, packages like numpy, pandas or Pytorch only render non RC releases on their docs but announce the RC changelogs via Github releases.
This PR is fine with me but I just wanted to mention that for discussion.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1752 +/- ##
==========================================
- Coverage 86.99% 84.52% -2.48%
==========================================
Files 40 40
Lines 6053 6053
==========================================
- Hits 5266 5116 -150
- Misses 787 937 +150 |
Co-authored-by: Philipp A <flying-sheep@web.de>
This would be an idea. It’s pretty manual again and we wanted less manual process. IDK if we can automate this better.
https://scverse.zulipchat.com/#narrow/channel/315185-general/topic/AnnData.200.2E11.2E0/near/481456047