Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libzkp): upgrade libzkp to v0.9.4 #973

Merged
merged 4 commits into from
Oct 2, 2023
Merged

fix(libzkp): upgrade libzkp to v0.9.4 #973

merged 4 commits into from
Oct 2, 2023

Conversation

silathdiir
Copy link
Contributor

@silathdiir silathdiir commented Sep 27, 2023

Purpose or design rationale of this PR

Could reference this notion page for details.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@silathdiir silathdiir added breaking-change bump-version Bump the version tag for deployment labels Sep 27, 2023
@silathdiir silathdiir changed the title [WIP] fix(libzkp): upgrade libzkp to v0.9.4 [Testing] fix(libzkp): upgrade libzkp to v0.9.4 Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #973 (1863ea1) into develop (76d66eb) will not change coverage.
The diff coverage is n/a.

❗ Current head 1863ea1 differs from pull request most recent head 62d5e1f. Consider uploading reports for the commit 62d5e1f to get more accurate results

@@           Coverage Diff            @@
##           develop     #973   +/-   ##
========================================
  Coverage    48.18%   48.18%           
========================================
  Files          100      100           
  Lines        10579    10579           
========================================
  Hits          5098     5098           
  Misses        5060     5060           
  Partials       421      421           
Flag Coverage Δ
common 54.56% <ø> (ø)
coordinator 18.94% <ø> (ø)
database 42.85% <ø> (ø)
rollup 66.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@silathdiir
Copy link
Contributor Author

test_zkp could pass.

Screen Shot 2023-09-27 at 7 07 57 PM

@silathdiir silathdiir changed the title [Testing] fix(libzkp): upgrade libzkp to v0.9.4 fix(libzkp): upgrade libzkp to v0.9.4 Sep 27, 2023
johnsonjie
johnsonjie previously approved these changes Oct 2, 2023
@silathdiir silathdiir merged commit 6f72d04 into develop Oct 2, 2023
@silathdiir silathdiir deleted the libzkp-v0.9.4 branch October 2, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants