-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(observability):add ready&health check api for k8s #938
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #938 +/- ##
===========================================
- Coverage 50.47% 50.46% -0.02%
===========================================
Files 95 96 +1
Lines 9953 9992 +39
===========================================
+ Hits 5024 5042 +18
- Misses 4523 4537 +14
- Partials 406 413 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
…to feat/add-api-ready
CI has failed. |
bloomFilter Is there a risk of being overwritten? |
GetMonitor how about directly return a new Monitor instance? Although We know |
Seems don't have this problem. |
Purpose or design rationale of this PR
Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?
https://scrollco.slack.com/archives/C04MC0S70A3/p1692170426168649
add ready&health check api in observability module
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?