Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve rollup readme #917

Merged
merged 4 commits into from
Sep 2, 2023
Merged

doc: improve rollup readme #917

merged 4 commits into from
Sep 2, 2023

Conversation

icemelon
Copy link
Member

@icemelon icemelon commented Sep 2, 2023

Purpose or design rationale of this PR

improve rollup readme

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • docs: Documentation-only changes

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #917 (4df4c0e) into develop (d3c2e34) will not change coverage.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #917   +/-   ##
========================================
  Coverage    49.27%   49.27%           
========================================
  Files           95       95           
  Lines         9888     9888           
========================================
  Hits          4872     4872           
  Misses        4612     4612           
  Partials       404      404           
Flag Coverage Δ
rollup 62.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

georgehao
georgehao previously approved these changes Sep 2, 2023
@0xmountaintop 0xmountaintop merged commit a2fe246 into develop Sep 2, 2023
11 checks passed
@0xmountaintop 0xmountaintop deleted the doc/rollup-readme branch September 2, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants