Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(rollup_relayer): add chain_monitor client (#885)" #899

Closed
wants to merge 3 commits into from

Conversation

0xmountaintop
Copy link
Member

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #899 (e34cfbb) into develop (112e82a) will decrease coverage by 0.15%.
The diff coverage is 38.23%.

@@             Coverage Diff             @@
##           develop     #899      +/-   ##
===========================================
- Coverage    43.90%   43.75%   -0.15%     
===========================================
  Files           72       71       -1     
  Lines         7020     6954      -66     
===========================================
- Hits          3082     3043      -39     
+ Misses        3686     3662      -24     
+ Partials       252      249       -3     
Flag Coverage Δ
bridge 62.12% <ø> (-0.19%) ⬇️
bridge-history-api 12.14% <ø> (ø)
common 55.31% <39.39%> (+0.46%) ⬆️
coordinator 19.46% <ø> (ø)
database 42.85% <ø> (ø)
prover 27.48% <0.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
bridge/internal/config/relayer.go 67.69% <ø> (ø)
bridge/internal/controller/relayer/l2_relayer.go 42.00% <ø> (-1.80%) ⬇️
.../internal/controller/relayer/l2_relayer_metrics.go 100.00% <ø> (ø)
common/cmd/cmd_app.go 0.00% <0.00%> (ø)
common/docker/docker_app.go 46.78% <ø> (ø)
common/utils/utils.go 0.00% <ø> (ø)
prover/cmd/app/mock_app.go 0.00% <0.00%> (ø)
common/cmd/cmd.go 68.18% <100.00%> (-5.41%) ⬇️
common/docker/docker_db.go 56.96% <100.00%> (ø)
common/docker/docker_geth.go 52.83% <100.00%> (ø)

@georgehao georgehao closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants