Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rollup_relayer): add chain_monitor client #885

Merged
merged 44 commits into from
Aug 31, 2023

Conversation

mask-pp
Copy link
Contributor

@mask-pp mask-pp commented Aug 28, 2023

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

Check every batch status before sending finalizeBatchProof tx.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #885 (ec542d0) into develop (f553a70) will decrease coverage by 7.22%.
The diff coverage is 41.00%.

❗ Current head ec542d0 differs from pull request most recent head 1274adc. Consider uploading reports for the commit 1274adc to get more accurate results

@@             Coverage Diff             @@
##           develop     #885      +/-   ##
===========================================
- Coverage    50.93%   43.72%   -7.22%     
===========================================
  Files           60       72      +12     
  Lines         5617     6967    +1350     
===========================================
+ Hits          2861     3046     +185     
- Misses        2513     3668    +1155     
- Partials       243      253      +10     
Flag Coverage Δ
bridge 62.21% <50.00%> (-0.16%) ⬇️
bridge-history-api 12.14% <ø> (?)
common 54.85% <36.66%> (-0.38%) ⬇️
coordinator 19.46% <ø> (ø)
database 42.85% <ø> (ø)
prover 27.32% <0.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
bridge/internal/config/relayer.go 67.69% <ø> (ø)
common/cmd/cmd_app.go 0.00% <0.00%> (ø)
common/docker/docker_app.go 46.78% <ø> (ø)
common/utils/http.go 0.00% <0.00%> (ø)
common/utils/utils.go 0.00% <0.00%> (ø)
prover/cmd/app/mock_app.go 0.00% <0.00%> (ø)
bridge/internal/controller/relayer/l2_relayer.go 42.97% <36.66%> (-0.42%) ⬇️
.../internal/controller/relayer/l2_relayer_metrics.go 100.00% <100.00%> (ø)
common/cmd/cmd.go 73.58% <100.00%> (+7.67%) ⬆️
common/docker/docker_db.go 56.96% <100.00%> (ø)
... and 1 more

... and 11 files with indirect coverage changes

@mask-pp mask-pp requested review from georgehao, Thegaram, 0xmountaintop and colinlyguo and removed request for georgehao and Thegaram August 28, 2023 07:47
@mask-pp
Copy link
Contributor Author

mask-pp commented Aug 30, 2023

This PR is based on https://github.com/scroll-tech/testnet/pull/703.

common/utils/utils.go Outdated Show resolved Hide resolved
mask-pp and others added 2 commits August 30, 2023 18:19
Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
@0xmountaintop 0xmountaintop changed the title Add batch status check logic feat(rollup_relayer): add chain_monitor client Aug 31, 2023
@0xmountaintop 0xmountaintop merged commit 3958e8b into develop Aug 31, 2023
@0xmountaintop 0xmountaintop deleted the feat/add_chain_monitor branch August 31, 2023 12:15
0xmountaintop added a commit that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants