Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coordinator): fix TestApis #883

Merged
merged 3 commits into from
Aug 28, 2023
Merged

fix(coordinator): fix TestApis #883

merged 3 commits into from
Aug 28, 2023

Conversation

0xmountaintop
Copy link
Member

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@0xmountaintop 0xmountaintop changed the title Fix/UUID fix(coordinator): fix TestApis Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #883 (b02d0a4) into develop (1dfca3b) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head b02d0a4 differs from pull request most recent head 635d83b. Consider uploading reports for the commit 635d83b to get more accurate results

@@             Coverage Diff             @@
##           develop     #883      +/-   ##
===========================================
+ Coverage    50.91%   50.93%   +0.01%     
===========================================
  Files           60       60              
  Lines         5601     5601              
===========================================
+ Hits          2852     2853       +1     
+ Misses        2506     2505       -1     
  Partials       243      243              
Flag Coverage Δ
bridge 62.44% <ø> (ø)
common 55.16% <ø> (+0.08%) ⬆️
coordinator 19.46% <ø> (ø)
database 42.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@0xmountaintop 0xmountaintop merged commit 30ad0bf into develop Aug 28, 2023
@0xmountaintop 0xmountaintop deleted the fix/uuid branch August 28, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant