Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollup-relayer): block l1 commit calldata and gas estimation #882

Merged

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Aug 26, 2023

Purpose or design rationale of this PR

count block context for each block, not for each transaction.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #882 (99b3ea7) into develop (30ad0bf) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #882      +/-   ##
===========================================
- Coverage    50.93%   50.91%   -0.02%     
===========================================
  Files           60       60              
  Lines         5601     5599       -2     
===========================================
- Hits          2853     2851       -2     
  Misses        2505     2505              
  Partials       243      243              
Flag Coverage Δ
bridge 62.44% <ø> (ø)
coordinator 19.46% <ø> (ø)
database 42.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
common/types/block.go 93.20% <ø> (-0.13%) ⬇️

@colinlyguo colinlyguo self-assigned this Aug 28, 2023
@georgehao georgehao merged commit dba097e into develop Aug 28, 2023
19 of 20 checks passed
@georgehao georgehao deleted the fix-rollup-relayer-commit-l1-calldata-and-gas-estimation branch August 28, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants