Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollup-relayer): chunk and batch proposer metrics #873

Merged
merged 6 commits into from
Aug 24, 2023

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Aug 24, 2023

Purpose or design rationale of this PR

Fix chunk proposer and batch proposer metrics submission.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #873 (4068dd9) into develop (2840485) will increase coverage by 0.09%.
The diff coverage is 52.38%.

@@             Coverage Diff             @@
##           develop     #873      +/-   ##
===========================================
+ Coverage    51.19%   51.28%   +0.09%     
===========================================
  Files           60       60              
  Lines         5577     5588      +11     
===========================================
+ Hits          2855     2866      +11     
  Misses        2483     2483              
  Partials       239      239              
Flag Coverage Δ
bridge 63.51% <52.38%> (+0.13%) ⬆️
common 55.43% <ø> (ø)
coordinator 19.15% <ø> (ø)
database 42.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...idge/internal/controller/watcher/chunk_proposer.go 67.85% <50.00%> (+1.03%) ⬆️
...idge/internal/controller/watcher/batch_proposer.go 62.50% <57.14%> (+0.73%) ⬆️

Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
@Thegaram Thegaram merged commit 24a0fd0 into develop Aug 24, 2023
20 checks passed
@Thegaram Thegaram deleted the fix-rollup-relayer-chunk-and-batch-proposer-metrics branch August 24, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants