-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(coordinator): prover task record unique #845
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #845 +/- ##
===========================================
+ Coverage 50.74% 50.93% +0.19%
===========================================
Files 60 60
Lines 5624 5601 -23
===========================================
- Hits 2854 2853 -1
+ Misses 2526 2505 -21
+ Partials 244 243 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
icemelon
previously approved these changes
Aug 21, 2023
Thegaram
reviewed
Aug 22, 2023
in general looks good. can you address @Thegaram's concern #845 (comment)?
|
…ll into feat/prover_task_unique
…ll into feat/prover_task_unique
0xmountaintop
changed the title
Feat(coordinator): prover task record unique
feat(coordinator): prover task record unique
Aug 23, 2023
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
…ll into feat/prover_task_unique
0xmountaintop
previously approved these changes
Aug 23, 2023
Thegaram
reviewed
Aug 23, 2023
…ll into feat/prover_task_unique
0xmountaintop
previously approved these changes
Aug 24, 2023
…ll into feat/prover_task_unique
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?
make the prover_task from one to multiple. but need keep it unique
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated?Breaking change label
Does this PR have the
breaking-change
label?