Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts): bench test for ScrollChain #721

Merged
merged 15 commits into from
Sep 1, 2023

Conversation

zimpha
Copy link
Member

@zimpha zimpha commented Aug 4, 2023

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

This PR add benchmark tests for ScrollChain to compute the gas usage for different inputs.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@zimpha zimpha requested a review from icemelon August 4, 2023 11:39
@zimpha zimpha self-assigned this Aug 4, 2023
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

LCOV of commit 46dadab during Contracts #1349

Summary coverage rate:
  lines......: 52.6% (992 of 1885 lines)
  functions..: 67.3% (222 of 330 functions)
  branches...: no data found

Files changed coverage rate: n/a

0xmountaintop
0xmountaintop previously approved these changes Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #721 (dffa744) into develop (44b9241) will decrease coverage by 0.17%.
The diff coverage is n/a.

❗ Current head dffa744 differs from pull request most recent head 46dadab. Consider uploading reports for the commit 46dadab to get more accurate results

@@             Coverage Diff             @@
##           develop     #721      +/-   ##
===========================================
- Coverage    43.90%   43.74%   -0.17%     
===========================================
  Files           72       72              
  Lines         7019     6988      -31     
===========================================
- Hits          3082     3057      -25     
+ Misses        3685     3680       -5     
+ Partials       252      251       -1     
Flag Coverage Δ
bridge 62.14% <ø> (-0.19%) ⬇️
common 54.85% <ø> (ø)
coordinator 19.46% <ø> (ø)
database 42.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

icemelon
icemelon previously approved these changes Sep 1, 2023
@icemelon icemelon merged commit 38f64e7 into develop Sep 1, 2023
3 checks passed
@icemelon icemelon deleted the feat/scroll_chain_bench_test branch September 1, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants