-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(coordinator): add prover rest api #716
feat(coordinator): add prover rest api #716
Conversation
…oll into feat/restful-api-for-prover
…/scroll into feat/restful-api-for-prover1
…tful-api-for-prover1
…/scroll into feat/restful-api-for-prover1
…oll into feat/restful-api-for-prover1
in general, looks good. |
…/scroll into feat/restful-api-for-prover1
} | ||
|
||
// load and send chunk tasks | ||
chunkTasks, err := cp.chunkOrm.UpdateUnassignedChunkReturning(ctx, getTaskParameter.ProverHeight, 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current logic only support assigning to a(!) prover?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or maybe we can ignore this now, and change to support "multiple prover per task" later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, on sepolia will don't have this feature. I'll add the feature later: support multiple prover per task
…/scroll into feat/restful-api-for-prover1
Purpose or design rationale of this PR
Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?
What does this PR do?
optimize the communication between coordinator and prover.
Why does it do it?
Currently, the coordinator can't deploy multiple replicas, for high availability, we need enhance it
How does it do it?
https://www.notion.so/scrollzkp/Proposal-Interactive-mode-for-coordinator-and-prover-f4340330f37743ebab796c6e20f972b2
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated?Breaking change label
Does this PR have the
breaking-change
label?