Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coordinator): add prover rest api #716

Merged
merged 75 commits into from
Aug 4, 2023

Conversation

georgehao
Copy link
Member

@georgehao georgehao commented Aug 3, 2023

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

What does this PR do?
optimize the communication between coordinator and prover.

Why does it do it?
Currently, the coordinator can't deploy multiple replicas, for high availability, we need enhance it

How does it do it?
https://www.notion.so/scrollzkp/Proposal-Interactive-mode-for-coordinator-and-prover-f4340330f37743ebab796c6e20f972b2

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@0xmountaintop
Copy link
Member

in general, looks good.
I need to carefully review coordinator/internal/logic/provertask/chunk_prover_task.go again

}

// load and send chunk tasks
chunkTasks, err := cp.chunkOrm.UpdateUnassignedChunkReturning(ctx, getTaskParameter.ProverHeight, 1)
Copy link
Member

@0xmountaintop 0xmountaintop Aug 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current logic only support assigning to a(!) prover?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe we can ignore this now, and change to support "multiple prover per task" later

Copy link
Member Author

@georgehao georgehao Aug 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, on sepolia will don't have this feature. I'll add the feature later: support multiple prover per task

@georgehao georgehao merged commit fcf34ed into pull-model-prover-client Aug 4, 2023
14 of 17 checks passed
@georgehao georgehao deleted the feat/restful-api-for-prover1 branch August 4, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants