-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(coordinator & prover): RESTful API #696
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinlyguo
force-pushed
the
pull-model-prover-client
branch
4 times, most recently
from
August 1, 2023 12:45
c0fc89b
to
2396dc7
Compare
colinlyguo
force-pushed
the
pull-model-prover-client
branch
from
August 1, 2023 13:05
2396dc7
to
61d8b48
Compare
colinlyguo
changed the title
[WIP] new prover client
[WIP] refactor(prover): RESTful client
Aug 1, 2023
colinlyguo
changed the title
[WIP] refactor(prover): RESTful client
refactor(prover): RESTful client
Aug 2, 2023
colinlyguo
force-pushed
the
pull-model-prover-client
branch
from
August 2, 2023 08:27
3252cf7
to
4db1565
Compare
Thegaram
reviewed
Aug 3, 2023
Co-authored-by: colinlyguo <colinlyguo@scroll.io>
colinlyguo
changed the title
refactor(prover): RESTful client
refactor(coordinator & prover): RESTful APIs
Aug 4, 2023
colinlyguo
changed the title
refactor(coordinator & prover): RESTful APIs
refactor(coordinator & prover): RESTful API
Aug 4, 2023
georgehao
approved these changes
Aug 5, 2023
Merging now so that we can deploy and test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
What does this PR do?
This PR optimizes the communication between coordinator and prover.
Why does it do it?
How does it do it?
Design doc: https://www.notion.so/scrollzkp/Proposal-Interactive-mode-for-coordinator-and-prover-f4340330f37743ebab796c6e20f972b2
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated?Breaking change label
Does this PR have the
breaking-change
label?