Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: push docker images to correct user #1538

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

Thegaram
Copy link
Contributor

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

The access token we are currently using is for user peterscroll, but we want to push images with the tag scrolltech/....

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

Copy link
Member

@sbaizet-ledger sbaizet-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Thegaram Thegaram merged commit 3353e36 into develop Oct 15, 2024
10 checks passed
@Thegaram Thegaram deleted the fix-push-docker-images-to-correct-user branch October 15, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants