fix (prover): close file handles used in prover (#1007)

Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com>
scroll-tech · Nov 7, 2023 · 4aa5d5c · 4aa5d5c
1 parent 486c7ee
commit 4aa5d5c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/prover/core/prover.go b/prover/core/prover.go
@@ -236,6 +236,11 @@ func (p *ProverCore) mayDumpProof(id string, proofByt []byte) error {
 	if err != nil {
 		return err
 	}
+	defer func() {
+		if err = f.Close(); err != nil {
+			log.Error("failed to close proof dump file", "id", id, "error", err)
+		}
+	}()
 	log.Info("Saving proof", "task-id", id)
 	_, err = f.Write(proofByt)
 	return err

diff --git a/prover/core/prover_test.go b/prover/core/prover_test.go
@@ -92,6 +92,7 @@ func TestFFI(t *testing.T) {
 func readChunkTrace(filePat string, as *assert.Assertions) []*types.BlockTrace {
 	f, err := os.Open(filePat)
 	as.NoError(err)
+	defer as.NoError(f.Close())
 	byt, err := io.ReadAll(f)
 	as.NoError(err)
 
@@ -104,6 +105,7 @@ func readChunkTrace(filePat string, as *assert.Assertions) []*types.BlockTrace {
 func readVk(filePat string, as *assert.Assertions) string {
 	f, err := os.Open(filePat)
 	as.NoError(err)
+	defer as.NoError(f.Close())
 	byt, err := io.ReadAll(f)
 	as.NoError(err)