Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scroll l1 message transaction #41

Merged
merged 11 commits into from
Nov 28, 2024
Merged

Conversation

greged93
Copy link
Collaborator

@greged93 greged93 commented Nov 21, 2024

Adds the Scroll L1 message transaction as a variant in the Reth primitive enum Transaction.
L1 message transaction doesn't require a bincode "bridge" implementation because it doesn't contain optionally serializable fields.

Builds towards #7

Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
…ilation

Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
frisitano
frisitano previously approved these changes Nov 28, 2024
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments inline. This can be merged once they are addressed.

crates/primitives/src/alloy_compat.rs Show resolved Hide resolved
crates/optimism/payload/Cargo.toml Outdated Show resolved Hide resolved
crates/primitives/src/transaction/mod.rs Outdated Show resolved Hide resolved
crates/primitives/src/receipt.rs Show resolved Hide resolved
crates/scroll/primitives/src/l1_transaction.rs Outdated Show resolved Hide resolved
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. LGTM.

@frisitano frisitano merged commit 1c9ebaf into scroll Nov 28, 2024
39 checks passed
@frisitano frisitano deleted the feat/scroll-transaction branch November 28, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants