rename-internal

[naure]

The program column for immediates has become complex and it cannot be summarized with a name, so rename it to "internal".

[matthiasgoergens]

I appreciate the sentiment, but I think the right conclusion to draw here is that the field doesn't make sense and should be replaced by something saner.

If you are interested, I can give you a detailed proposal and even a PR.

[naure]

If you are interested, I can give you a detailed proposal and even a PR.

If you have something simpler in mind, let's hear it. But changing this any further is really low priority. Especially given the low test coverage and low type safety.

Tests would be welcome!
More type safety too!

[matthiasgoergens]

My proposal would fix some of the safety issues.

But it sounds like you wouldn't review a proposal (and no one else here would either). So I don't think I care about pushing yet another languishing PR into the void at this point in time.

Your proposal here doesn't make the existing code worse as far as I can tell. So I don't mind it.

[naure]

No if you have it in mind already do write it as an issue.

Then, the first rule of refactoring is to avoid regressions by increasing tests and documentation coverage. That has great benefits and no drawbacks which is why I'm suggesting that direction now.

[hero78119]

Nice! the new naming hide much information and looks for simpler now 👍

[KimiWu123]

imm_internal is more confusing for me. 1. what _internal means?, 2 'imm_or_funct7does returnsfunct7` in R-type.

[naure]

It can contain funct7 but also others things depending on instructions. So it's a generic container with a generic name.

[naure]

Mixed opinions on this, but I do want people to go learn the "internal" logic, instead of assuming something from an imprecise name.

[matthiasgoergens]

No if you have it in mind already do write it as an issue.

See #524