Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git action for project structure #378

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Conversation

axif0
Copy link
Contributor

@axif0 axif0 commented Oct 15, 2024

Contributor checklist


Description

Validates src/scribe_data/language_data_extraction directory, data-type directories, and their subdirectories.
Checks for unexpected or missing sub-subdirectories based on language-specific expectations.
Fix the unstructured some of the language and data-type.

Related issue

Copy link

github-actions bot commented Oct 15, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 16, 2024
@andrewtavis
Copy link
Member

Apparently was really needed, @axif0 :) One final thing: some of the query files aren't named properly. Can we also include a check to make sure that they're all named query_...s - i.e. each should end in s :)

@andrewtavis andrewtavis self-requested a review October 16, 2024 11:11
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll actually merge this now, @axif0 as we have someone who needs the paths to be valid for another part of the project 😊 Thanks so much for this! Can you send along the errors for invalid file names in another PR?

@andrewtavis andrewtavis merged commit 8e1c2b5 into scribe-org:main Oct 16, 2024
5 checks passed
@axif0
Copy link
Contributor Author

axif0 commented Oct 16, 2024

@andrewtavis what about the .py files? Should I skip those py file ? Or any special condition, Can you please clarify.. I was't sure earlier back then.. and forgot to ask you. Sorry again.

@axif0 axif0 deleted the workflow branch October 17, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants