-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create query_adverbs.sparql #368
Conversation
adverbs for Czech
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
This query does have forms, @Otom-obhazi. Can you please do the following:
Once that's done we'll be good to merge! Let me know if you need any help :) |
Okay
…On Tue, 15 Oct 2024, 5:26 pm Andrew Tavis McAllister, < ***@***.***> wrote:
This query does have forms, @Otom-obhazi <https://github.com/Otom-obhazi>.
Can you please do the following:
- Remove DISTINCT
- Check out the query for Spanish adverbs
<https://github.com/scribe-org/Scribe-Data/blob/main/src/scribe_data/language_data_extraction/Spanish/adverbs/query_adverbs.sparql>
- Edit this query to also get comparative and superlative forms
Once that's done we'll be good to merge! Let me know if you need any help
:)
—
Reply to this email directly, view it on GitHub
<#368 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQTIX2H5GYOU36LBMJIIPLLZ3U65BAVCNFSM6AAAAABP7A5OP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJUGQ4DGNZZHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Are you going to continue to work on this one now, @Otom-obhazi? I think if you follow what I have for other queries now it'll go well? Note that we're getting all the forms in one line separated by commas, btw, which will make the queries more readable :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks much for this, @Otom-obhazi! Clearing the PRs out so it doesn't get too much :)
is this good |
adverbs for Czech
Contributor checklist
Description
Related issue