Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create query_adverbs.sparql #368

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Conversation

Otom-obhazi
Copy link
Contributor

adverbs for Czech

Contributor checklist


Description

Related issue

  • #ISSUE_NUMBER

adverbs for Czech
Copy link

github-actions bot commented Oct 15, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 15, 2024
@andrewtavis andrewtavis self-requested a review October 15, 2024 13:02
@andrewtavis
Copy link
Member

This query does have forms, @Otom-obhazi. Can you please do the following:

  • Remove DISTINCT
  • Check out the query for Spanish adverbs
  • Edit this query to also get comparative and superlative forms

Once that's done we'll be good to merge! Let me know if you need any help :)

@Otom-obhazi
Copy link
Contributor Author

Otom-obhazi commented Oct 15, 2024 via email

@andrewtavis
Copy link
Member

Are you going to continue to work on this one now, @Otom-obhazi? I think if you follow what I have for other queries now it'll go well? Note that we're getting all the forms in one line separated by commas, btw, which will make the queries more readable :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much for this, @Otom-obhazi! Clearing the PRs out so it doesn't get too much :)

@andrewtavis andrewtavis merged commit 9fdb576 into scribe-org:main Oct 16, 2024
5 checks passed
@Otom-obhazi
Copy link
Contributor Author

This query does have forms, @Otom-obhazi. Can you please do the following:

  • Remove DISTINCT
  • Check out the query for Spanish adverbs
  • Edit this query to also get comparative and superlative forms

Once that's done we'll be good to merge! Let me know if you need any help :)

is this good
#368 (comment)

@Otom-obhazi
Copy link
Contributor Author

#403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants