-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add workflow check_query_identifiers and dummy script #339 #350
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
Can we get the branch actions to look like this, @catreedle:
That way the workflow reruns on future commits? :) |
Updated it. Thank you! @andrewtavis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented out the actions in the workflow so that we can bring this in now and eventually bring it into @DeleMike's PR, @catreedle :) Wonderful work! Thanks so much 😊
# - name: Set up Python ${{ matrix.python-version }} | ||
# uses: actions/setup-python@v4 | ||
# with: | ||
# python-version: ${{ matrix.python-version }} | ||
|
||
# - name: Install dependencies | ||
# run: | | ||
# python -m pip install --upgrade uv | ||
# uv venv | ||
# uv pip install -r requirements.txt | ||
|
||
# - name: Activate virtualenv | ||
# run: | | ||
# . .venv/bin/activate | ||
# echo PATH=$PATH >> $GITHUB_ENV | ||
|
||
# - name: Run Python script | ||
# run: python src/scribe_data/check/check_query_identifiers.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @catreedle and @andrewtavis, do you know why this was commented out? check_query_identifiers.py
is done and I need to be sure all the commands are useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanna know why, in the steps, we are setting up Python, installing dependencies, and activating a virtual environment but .github/workflows/check_project_structure.yaml
does not have this style? is there a reason why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is commented out so we don't get errors before everything is hooked up :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we don't need the environment for this one and it'd make sense to simplify the steps 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andrewtavis for the response!
yeah, maybe we don't need it. I can raise a PR and we quickly evaluate it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @DeleMike!
Contributor checklist
Description
This PR adds a new workflow that would run check_query_identifiers.py
It has been tested on a forked repository using a dummy script.
Any feedback or suggestions are greatly appreciated.
Related issue