Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert CONTRIBUTING_NO_BACK_LINKS.md file to rst format #103

Merged
merged 14 commits into from
Mar 17, 2024

Conversation

mhmohona
Copy link
Member

Contributor checklist


Description

Convert CONTRIBUTING_NO_BACK_LINKS.md file to rst format for better readability in doc.

Related issue

Copy link

github-actions bot commented Mar 12, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@@ -1,229 +0,0 @@
# Contributing to Scribe-Data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check what the conflicts are exactly, but do make sure to take a look and resolve what the conflicts may be, so we are able to merge 😁

Looks like the conflict is on this file, but since the file is getting deleted anyway, my guess is that could just be there are some upstream changes that need to get pull down to the source branch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wkyoshida, phew, the conflict has been resolved now. :D

@mhmohona mhmohona reopened this Mar 12, 2024
@mhmohona mhmohona requested a review from wkyoshida March 12, 2024 23:31
@andrewtavis andrewtavis self-requested a review March 17, 2024 00:22
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two most recent commits are just formatting for the .rst contributing file and changing it so it's in the _static directory :) Thanks for all the work in converting it over, @mhmohona! Thanks also for the initial review, @wkyoshida :)

@andrewtavis andrewtavis merged commit 4f08fc2 into scribe-org:main Mar 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown to reStructuredText Format Issues
3 participants