Skip to content

Commit

Permalink
#68 fix of Portuguese past perfect tense via new PID
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewtavis committed Jun 8, 2024
1 parent 63cca33 commit 54a5e36
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 6 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ Emojis for the following are chosen based on [gitmoji](https://gitmoji.dev/).
- The documentation has been given a new layout with the logo in the top left ([#90](https://github.com/scribe-org/Scribe-Data/issues/90)).
- The documentation now has links to the code at the top of each page ([#91](https://github.com/scribe-org/Scribe-Data/issues/91)).

### 🐞 Bug Fixes

- Annotation bugs were removed like repeat or empty values.
- Perfect tenses of Portuguese verbs were fixed via finding the appropriate PID ([#68](https://github.com/scribe-org/Scribe-Data/issues/68)).
- Note that the most common past perfect property is not the standard one, so this will need to be fixed.

### ♻️ Code Refactoring

- [pre-commit](https://pre-commit.com/) have been added to the repo to improve the development experience ([#137](https://github.com/scribe-org/Scribe-Data/issues/137)).
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,47 +84,47 @@ WHERE {
wikibase:grammaticalFeature wd:Q21714344 ;
wikibase:grammaticalFeature wd:Q110786 ;
wikibase:grammaticalFeature wd:Q682111 ;
wikibase:grammaticalFeature wd:Q23663136 ;
wikibase:grammaticalFeature wd:Q64005357 ;
} .
OPTIONAL {
?lexeme ontolex:lexicalForm ?perfSPSForm .
?perfSPSForm ontolex:representation ?perfSPS ;
wikibase:grammaticalFeature wd:Q51929049 ;
wikibase:grammaticalFeature wd:Q110786 ;
wikibase:grammaticalFeature wd:Q682111 ;
wikibase:grammaticalFeature wd:Q23663136 ;
wikibase:grammaticalFeature wd:Q64005357 ;
} .
OPTIONAL {
?lexeme ontolex:lexicalForm ?perfTPSForm .
?perfTPSForm ontolex:representation ?perfTPS ;
wikibase:grammaticalFeature wd:Q51929074 ;
wikibase:grammaticalFeature wd:Q110786 ;
wikibase:grammaticalFeature wd:Q682111 ;
wikibase:grammaticalFeature wd:Q23663136 ;
wikibase:grammaticalFeature wd:Q64005357 ;
} .
OPTIONAL {
?lexeme ontolex:lexicalForm ?perfFPPForm .
?perfFPPForm ontolex:representation ?perfFPP ;
wikibase:grammaticalFeature wd:Q21714344 ;
wikibase:grammaticalFeature wd:Q146786 ;
wikibase:grammaticalFeature wd:Q682111 ;
wikibase:grammaticalFeature wd:Q23663136 ;
wikibase:grammaticalFeature wd:Q64005357 ;
} .
OPTIONAL {
?lexeme ontolex:lexicalForm ?perfSPPForm .
?perfSPPForm ontolex:representation ?perfSPP ;
wikibase:grammaticalFeature wd:Q51929049 ;
wikibase:grammaticalFeature wd:Q146786 ;
wikibase:grammaticalFeature wd:Q682111 ;
wikibase:grammaticalFeature wd:Q23663136 ;
wikibase:grammaticalFeature wd:Q64005357 ;
} .
OPTIONAL {
?lexeme ontolex:lexicalForm ?perfTPPForm .
?perfTPPForm ontolex:representation ?perfTPP ;
wikibase:grammaticalFeature wd:Q51929074 ;
wikibase:grammaticalFeature wd:Q146786 ;
wikibase:grammaticalFeature wd:Q682111 ;
wikibase:grammaticalFeature wd:Q23663136 ;
wikibase:grammaticalFeature wd:Q64005357 ;
} .

# Past Imperfect
Expand Down

0 comments on commit 54a5e36

Please sign in to comment.