-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional Language Detect #932
Conversation
regarding adding |
HI @lopuhin, I am actually still developing and testing so I have not deleted it but will do that but in the end, I will clean codes and remove them. |
Hey @gavishpoddar good job! 💪 I left some comments. We will iterate over this code and probably the result will be quite different, but really good to see that you are getting results so quickly 🚀 Let me know if there's something you need any clarification on. 😄 |
…into pr/gavishpoddar/932
Co-authored-by: Marc Hernández <noviluni@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job! ✔️ 🚀
Really happy to see this happening 🎉 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great PR @gavishpoddar , added some minor notes, I think it's basically ready to be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @gavishpoddar 👍
@gavishpoddar congrats on the merge, great work 👍 @noviluni sorry that I didn't ask before merging, I hope a merge commit is fine, or would you prefer a squash and merge? |
Thanks for the merge :) |
Hi @lopuhin, sorry for the late answer. I prefer to squash because in that way it is easier for me to build the changelog when releasing a new version, but no problem, it is fine :) (Congrats Gavish! 💪 ) |
Implementing optional language detection and allow the creation of custom language detection libraries by users.
This work is currently in progress and this PR is created for the monitoring purpose by the maintainers to suggest progress.
This PR is currently not complete.
TODOS:
fasttext
model download.setup.py
for optional language detection.parse
,search_dates
andDateDataParser
.apply_setting
independent functions.dateparser-download
set default caching folder.dateparser-download
.detect_languages_func
->detect_languages_function