Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bloop 1.4.1 install #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Arthurm1
Copy link

Fixes Bloop install on Windows - Coursier channel use wasn't working for some reason.

No longer adds BLOOP_IN_SCOOP variable (was used for Python install)
No longer adds Bloop to path (I don't think this is needed as Scoop's shims are on path)
Creates a shim to bloop.bat instead of to bloop which didn't exist

Copy link
Contributor

@jvican jvican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for looking at this @Arthurm1 👍

},
"installer": {
"script": "coursier install --install-dir $dir --default-channels=false --channel $dir bloop"
"script": "coursier install --install-dir $dir bloop"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add --prefer-prebuilt true here to avoid coursier trying to compile the application to GraalVM native?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried installing bloop with scoop using this version of line 11. It appears to install properly but can someone double-check?

    "script": "coursier install --install-dir $dir --default-channels=false --channel io.get-coursier:apps bloop"

I'm still learning, but my (fuzzy) understanding is io.get-coursier:apps (ref: coursier docs) is a "Maven coordinate" and it redirects to bloop's most recent jar. Does that sound right?

},
"installer": {
"script": "coursier install --install-dir $dir --default-channels=false --channel $dir bloop"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of keeping these arguments to use the channel bloop-coursier.json? This is the channel we distribute in our release process and we use it in brew as well.

@Arthurm1
Copy link
Author

@jvican I don't know too much about Coursier but...

I've raised an issue coursier/coursier#1741 and depending on the result of that there may be no need to change the channel.

Up to you if you want to merge it so people can use Bloop on Windows now - or wait to see the outcome of the issue and we can close this and I can fix the small shim issue in ReleaseUtils for the next release.

As for the --prefer-prebuilt, I don't know the implications of using it. Maybe wait until coursier/coursier#1628 is addressed?

@kimxogus
Copy link

kimxogus commented Sep 2, 2020

Scoop install for bloop still breaks, hope this to be merged

@@ -3,14 +3,11 @@
"url": "https://github.com/scalacenter/bloop/releases/download/v1.4.1/bloop-coursier.json",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"url": "https://github.com/scalacenter/bloop/releases/download/v1.4.1/bloop-coursier.json",
"url": "https://github.com/scalacenter/bloop/releases/download/v1.4.8/bloop-coursier.json",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants