Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename FunctionnalProgrammingAndCategoryTheory and add migration #1500

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Rename FunctionnalProgrammingAndCategoryTheory and add migration #1500

merged 2 commits into from
Nov 19, 2024

Conversation

Philippus
Copy link
Contributor

@Philippus Philippus commented Nov 18, 2024 •
edited
Loading

Follow-up of #1494. It looks like migrations V25 and V26 are hidden in another directory.

@Philippus Philippus force-pushed the rename-FunctionnalProgrammingAndCategoryTheory branch from 9d01231 to 53972c6 Compare November 18, 2024 15:33
@Philippus Philippus force-pushed the rename-FunctionnalProgrammingAndCategoryTheory branch from 53972c6 to 9a029a9 Compare November 18, 2024 15:35
@Philippus
Copy link
Contributor Author

@adpi2 Any idea how to fix the failing test?

@adpi2
Copy link
Member

adpi2 commented Nov 19, 2024

It looks like migrations V25 and V26 are hidden in another directory.

Indeed, we can also write Scala migration files. Flyway can find them in the classpath and execute them.

@adpi2 Any idea how to fix the failing test?

We have a sub-module small-index which contains a JSON snapshot of projects and artifacts for the integration tests. Some of those projects contain "category" : "functionnal-programming-and-category-theory" which needs to be renamed. I allowed myself to push the update to your branch.

adpi2
adpi2 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix

@Philippus
Copy link
Contributor Author

Ah yes, I didn't check the sub-modules.

@adpi2 adpi2 merged commit 3c5d2fd into scalacenter:main Nov 19, 2024
3 checks passed
@Philippus Philippus deleted the rename-FunctionnalProgrammingAndCategoryTheory branch November 19, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adpi2 adpi2 adpi2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Philippus @adpi2