scaladex: 1024- Add a fullScalaVersion field in Artifact (#1) #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: added fullScalaVersion in Artifact class * feat: added languageToScalaVersion method * feat: added 2 fields in ArtifactTable * feat: added data migration file * feat: WIP new field added in artifor fullScalaVersion * fix: deleted POM files used for testing * fix: [error] (server / scalafixAll) scalafix.sbt.ScalafixFailed: TestError * fix: fixed " org.flywaydb.core.api.FlywayException: Found more than one migration with version 19" * fix: scalafmt formatting issues
adpi2
approved these changes
May 27, 2024
modules/server/src/main/scala/scaladex/server/service/ArtifactConverter.scala
Outdated
Show resolved
Hide resolved
modules/template/src/main/twirl/scaladex/view/project/artifact.scala.html
Outdated
Show resolved
Hide resolved
* refactor: based on Pr comments * fix: formatting * fix: formatting
Thank you for reviewing my PR, incorporated all suggested changes and merged the PR. |
|
Thanks @kannupriyakalra. I deployed this to https://index.scala-lang.org/. Let's wait a bit for new artifacts to come and we should see the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue- #1024