Feature/nfs integration #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuja-gautam
commented
May 27, 2024
| @@ -38,6 +38,7 @@ PML_SRC="./mcfs-main.pml" | |||
| PML_TEMP="./.pml_tmp" | |||
| PML_START_PATN="\/\* The persistent content of the file systems \*\/" | |||
| PML_END_PATN="\/\* Abstract state signatures of the file systems \*\/" | |||
| NFS_SUFFIX="server"; | |||
There was a problem hiding this comment.
Creates the fs directory on server with suffix -server
ahuja-gautam
commented
May 27, 2024
|
|
||
| static const char *dev_all[]= {"ram", "ram", "ram", "ram", | ||
| "mtdblock", "", "", "", | ||
| "", "ram", "ram", "ram", | ||
| "pmem"}; |
There was a problem hiding this comment.
Currently for nfs-ext4, this approach works.
To expand for using nfs with other file systems, this requires a more careful approach.
Maybe we can create an extra variable in globals.h to specify the underlying fs so that we can remove this dependency on ramdisk only
ahuja-gautam
commented
May 27, 2024
| @@ -77,6 +77,22 @@ void mountall() | |||
| char cmdbuf[PATH_MAX]; | |||
| snprintf(cmdbuf, PATH_MAX, "mount -t NOVA -o noatime %s %s", get_devlist()[i], get_basepaths()[i]); | |||
| ret = execute_cmd_status(cmdbuf); | |||
| } else if(is_nfs(get_fslist()[i])) { | |||
There was a problem hiding this comment.
Mount server
export directory
Mount nfsv3
ahuja-gautam
commented
May 27, 2024
| "exportfs -u %s", clientmountpath); | ||
| execute_cmd_status(cmdbuf); | ||
| } | ||
| if(retNFS == 0) { |
There was a problem hiding this comment.
Unmount ext4 only if nfs unmount succeeded
ahuja-gautam
commented
May 27, 2024
| if(retNFS == 0) { | ||
| retServerFS = umount2(serverbasepath,0); | ||
| } | ||
| ret = retNFS | retServerFS; |
There was a problem hiding this comment.
Both unmounts should succeed
ahuja-gautam
commented
May 27, 2024
| char cmdbuf[PATH_MAX]; | ||
| FILE *exports; | ||
|
|
||
| fprintf(stderr, "Will setup %s with underlying fs= %s\n", |
There was a problem hiding this comment.
Perform setup of underlying fs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.